[
https://issues.apache.org/jira/browse/PHOENIX-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785130#comment-16785130
]
Hadoop QA commented on PHOENIX-5172:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12961265/PHOENIX-5172.patch
against master branch at commit 6d13f5b70944f581a1b20a8ef48df0b84a6f2b6f.
ATTACHMENT ID: 12961265
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String stmt = "UPSERT INTO " + FQ_TABLE_NAME + "(mykey,
mycolumn, insert_date) VALUES (?, ?, ?)";
+ PreparedStatement ps = connection.prepareStatement("SELECT * FROM
" + FQ_TABLE_NAME+" WHERE INSERT_DATE = ?");
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.tool.PhoenixCanaryToolTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2392//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2392//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2392//console
This message is automatically generated.
> Harden queryserver canary tool with retries and effective logging
> -----------------------------------------------------------------
>
> Key: PHOENIX-5172
> URL: https://issues.apache.org/jira/browse/PHOENIX-5172
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.13.1
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Minor
> Fix For: 4.15.0, 4.14.2
>
> Attachments: PHOENIX-5172.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> # Add retry logic in getting connection url
> # Remove assigning schema_name to null
> # Add more logging
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
