[
https://issues.apache.org/jira/browse/PHOENIX-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795592#comment-16795592
]
Hadoop QA commented on PHOENIX-5172:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12962895/phoenix-5172.4.x-HBase-1.3.v3.patch
against 4.x-HBase-1.3 branch at commit
f256004ab45217eb736fda97b3d67cc77b183735.
ATTACHMENT ID: 12962895
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ LOG.error("Failed to get connection after multiple
retries; the connection is null");
+ connProps.setProperty("phoenix.schema.mapSystemTablesToNamespace",
String.valueOf(namespaceFlag));
+ connProps.setProperty("phoenix.schema.isNamespaceMappingEnabled",
String.valueOf(namespaceFlag));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.tool.ParameterizedPhoenixCanaryToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.trace.PhoenixTracingEndToEndIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2447//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2447//console
This message is automatically generated.
> Harden queryserver canary tool with retries and effective logging
> -----------------------------------------------------------------
>
> Key: PHOENIX-5172
> URL: https://issues.apache.org/jira/browse/PHOENIX-5172
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.13.1
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Minor
> Fix For: 4.15.0, 5.1.0, 4.14.2
>
> Attachments: phoenix-5172-4.x-1.3.patch,
> phoenix-5172.4.x-HBase-1.3.v1.patch, phoenix-5172.4.x-HBase-1.3.v2.patch,
> phoenix-5172.4.x-HBase-1.3.v3.patch
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> # Add retry logic in getting connection url
> # Remove assigning schema_name to null
> # Add more logging
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
