twdsilva commented on a change in pull request #444: PHOENIX-5148
URL: https://github.com/apache/phoenix/pull/444#discussion_r265335119
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/compile/GroupByCompiler.java
##########
@@ -63,9 +63,10 @@
private final boolean isOrderPreserving;
Review comment:
Do you need this boolean any more? Seems like we always should use
```orderPreservingTrackInfos``` to determine if its order preseving right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
