twdsilva commented on a change in pull request #444: PHOENIX-5148
URL: https://github.com/apache/phoenix/pull/444#discussion_r265732474
 
 

 ##########
 File path: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/join/SubqueryUsingSortMergeJoinIT.java
 ##########
 @@ -516,8 +516,8 @@ public void testAnyAllComparisonSubquery() throws 
Exception {
             assertEquals(rs.getString(2), "T6");
 
             assertFalse(rs.next());
-            
-            query = "SELECT /*+ USE_SORT_MERGE_JOIN*/ \"order_id\", name FROM 
" + tableName4 + " o JOIN " + tableName1 + " i ON o.\"item_id\" = i.\"item_id\" 
WHERE quantity != ANY(SELECT quantity FROM " + tableName4 + " q WHERE 
o.\"item_id\" = q.\"item_id\" GROUP BY quantity)";
+            //add order by to make the query result stable
+            query = "SELECT /*+ USE_SORT_MERGE_JOIN*/ \"order_id\", name FROM 
" + tableName4 + " o JOIN " + tableName1 + " i ON o.\"item_id\" = i.\"item_id\" 
WHERE quantity != ANY(SELECT quantity FROM " + tableName4 + " q WHERE 
o.\"item_id\" = q.\"item_id\" GROUP BY quantity) order by \"order_id\"";
 
 Review comment:
   what happens if we don't add the order by?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to