BinShi-SecularBird commented on a change in pull request #463: Phoenix stats
Initial Commit
URL: https://github.com/apache/phoenix/pull/463#discussion_r265803811
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java
##########
@@ -694,4 +694,138 @@ public TimeRange getRowTimestampRange() {
return rowTimestampRange;
}
+ public List<KeyRange> getRowKeyRanges(){
Review comment:
Could you add comments (function spec - The algorithm? What is the output?
Is the output KeyRange coalesced? Is the output guaranteed to be in "lower
bound inclusive and upper bound exclusive" format?) for this function? Need to
add test cases for all the cases mentioned in the func spec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
