BinShi-SecularBird commented on a change in pull request #463: Phoenix stats
Initial Commit
URL: https://github.com/apache/phoenix/pull/463#discussion_r265828435
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
##########
@@ -550,6 +550,76 @@ public BaseResultIterators(QueryPlan plan, Integer
perScanLimit, Integer offset,
}
return ranges;
}
+
+ private List<KeyRange> getRegionRowKeyRanges() throws SQLException {
+ List<HRegionLocation> regionLocations =
getRegionBoundaries(scanGrouper); //Load the region information
+
+ List<KeyRange> regionKeyRanges =
Lists.newArrayListWithExpectedSize(regionLocations.size());
Review comment:
I think we should use
Lists.newArrayListWithCapacity(regionLocations.size()), because we know the
exact size here. newArrayListWithExpectedSize actually use "given expectsize +
10% more" which we don't need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
