[
https://issues.apache.org/jira/browse/PHOENIX-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804504#comment-16804504
]
Hadoop QA commented on PHOENIX-5219:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12964110/PHOENIX-5219.patch
against master branch at commit 679dd55d504123b584eed88baecf98f197438bf9.
ATTACHMENT ID: 12964110
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.StringIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RowValueConstructorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2465//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2465//console
This message is automatically generated.
> Fix ConcurrentMutationsIT testLockUntilMVCCAdvanced and
> testRowLockDuringPreBatchMutateWhenIndexed failures on the master branch
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-5219
> URL: https://issues.apache.org/jira/browse/PHOENIX-5219
> Project: Phoenix
> Issue Type: Test
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Priority: Major
> Fix For: 5.1.0
>
> Attachments: PHOENIX-5219.patch
>
>
> These tests are failing because when we set the timestamp in
> {{Indexer.preBatchMutateWithExceptions}} we call
> {{KeyValueUtil.ensureKeyValues}} on the list of cells and then call
> {{KeyValue.getTimestampOffset}}
> Pre 2.0 the cells objects are NoTagsKeyValue (which extend KeyValue). In 2.0
> they are NoTagsByteBufferKeyValue (which doesn't extend KeyValue) so
> {{KeyValueUtil.ensureKeyValues}} returns a new list of objects on which we
> set the timestamp.
> The fix us to use {{CellUtil.setTimestamp}} to the set the timestamp
> directly on the cell.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
