[
https://issues.apache.org/jira/browse/PHOENIX-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16808044#comment-16808044
]
Thomas D'Silva commented on PHOENIX-5219:
-----------------------------------------
Yes these are the cells of the data table mutation (see
[https://github.com/apache/phoenix/blob/507e6b5a0f0c94cd85ed359cd04d92e849743a31/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java#L441).]
We need to set the timestamp of the data table mutation in order to handle the
case when the same Put occurs with the same time stamp from different clients
(see PHOENIX-4089 )
> Fix ConcurrentMutationsIT testLockUntilMVCCAdvanced and
> testRowLockDuringPreBatchMutateWhenIndexed failures on the master branch
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-5219
> URL: https://issues.apache.org/jira/browse/PHOENIX-5219
> Project: Phoenix
> Issue Type: Test
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Priority: Major
> Fix For: 5.1.0
>
> Attachments: PHOENIX-5219.patch
>
>
> These tests are failing because when we set the timestamp in
> {{Indexer.preBatchMutateWithExceptions}} we call
> {{KeyValueUtil.ensureKeyValues}} on the list of cells and then call
> {{KeyValue.getTimestampOffset}}
> Pre 2.0 the cells objects are NoTagsKeyValue (which extend KeyValue). In 2.0
> they are NoTagsByteBufferKeyValue (which doesn't extend KeyValue) so
> {{KeyValueUtil.ensureKeyValues}} returns a new list of objects on which we
> set the timestamp.
> The fix us to use {{CellUtil.setTimestamp}} to the set the timestamp
> directly on the cell.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
