gjacoby126 commented on a change in pull request #469: PHOENIX-5156 Consistent
Global Indexes for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r274181124
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##########
@@ -942,6 +942,9 @@ private boolean
addIndexesFromParentTable(MetaDataMutationResult result, Long re
} else {
indexesToAdd.add(PTableImpl.builderWithColumns(index,
getColumnsToClone(index))
.setTableName(modifiedIndexName)
+ .setParentName(view.getName())
Review comment:
Are you making assumptions elsewhere that this parent view metadata will be
set on the view index, and if so, what about pre-existing view indexes that
won't have it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
