gjacoby126 commented on a change in pull request #469: PHOENIX-5156 Consistent
Global Indexes for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r274184355
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java
##########
@@ -225,21 +213,6 @@ public void start(CoprocessorEnvironment e) throws
IOException {
// Metrics impl for the Indexer -- avoiding unnecessary indirection
for hadoop-1/2 compat
this.metricSource = MetricsIndexerSourceFactory.getInstance().create();
setSlowThresholds(e.getConfiguration());
-
- try {
- // get the specified failure policy. We only ever override it in
tests, but we need to do it
Review comment:
Is the goal to no longer have index failure policies because we'll never
have (client-visible) index failures?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
