[ 
https://issues.apache.org/jira/browse/PHOENIX-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818335#comment-16818335
 ] 

Swaroopa Kadam commented on PHOENIX-5243:
-----------------------------------------

Thanks for the feedback, [~ckulkarni] . I ll update the patch. 

I found this issue as I was working on 
https://issues.apache.org/jira/browse/PHOENIX-5235?filter=-1

Regarding changes for SQLLine, as I understood it doesn't do more than checking 
if underlying JDBC driver returns a row upon calling hasNext() and throws an 
exception if the underlying driver throws one too. With calling next() on the 
PRS and closing the PRS when scanner returns null caused an exception to appear 
on SQLline as PRS was closed agnostic to SQLline. 

Here is the exception stack: [https://github.com/julianhyde/sqlline/issues/289]

> PhoenixResultSet#next() closes the result set if scanner returns null
> ---------------------------------------------------------------------
>
>                 Key: PHOENIX-5243
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5243
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Swaroopa Kadam
>            Assignee: Swaroopa Kadam
>            Priority: Minor
>             Fix For: 4.14.2
>
>         Attachments: PHOENIX-5243.4.x-HBase-1.3.v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to