[
https://issues.apache.org/jira/browse/PHOENIX-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821575#comment-16821575
]
Hadoop QA commented on PHOENIX-5243:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12966412/PHOENIX-5243.4.x-HBase-1.3.v4.patch
against 4.x-HBase-1.3 branch at commit
b431a4e733e35977ee3445c4c9f70d37c48cbdef.
ATTACHMENT ID: 12966412
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 6 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ assertEquals(rs.getString(CLIENT_IP),
InetAddress.getLocalHost().getHostAddress());
+ assertEquals(rs.getString(CLIENT_IP),
InetAddress.getLocalHost().getHostAddress());
+ String logQuery = "SELECT * FROM " + SYSTEM_CATALOG_SCHEMA + ".\""
+ SYSTEM_LOG_TABLE + "\"";
+ assertEquals(rs.getString(BIND_PARAMETERS), loglevel
== LogLevel.TRACE ? "value5" : null);
+ assertEquals(rs.getString(CLIENT_IP),
InetAddress.getLocalHost().getHostAddress());
+ assertEquals(rs.getString(EXPLAIN_PLAN),
QueryUtil.getExplainPlan(explainRS));
+ assertTrue(LogLevel.TRACE == loglevel ?
rs.getString(SCAN_METRICS_JSON).contains("scanMetrics")
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.execute.PartialCommitIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SplitIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.iterate.RoundRobinResultIteratorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2515//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2515//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2515//console
This message is automatically generated.
> PhoenixResultSet#next() closes the result set if scanner returns null
> ---------------------------------------------------------------------
>
> Key: PHOENIX-5243
> URL: https://issues.apache.org/jira/browse/PHOENIX-5243
> Project: Phoenix
> Issue Type: Bug
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Minor
> Fix For: 4.14.2
>
> Attachments: PHOENIX-5243.4.x-HBase-1.3.v1.patch,
> PHOENIX-5243.4.x-HBase-1.3.v2.patch, PHOENIX-5243.4.x-HBase-1.3.v3.patch,
> PHOENIX-5243.4.x-HBase-1.3.v4.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
