[
https://issues.apache.org/jira/browse/PHOENIX-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848010#comment-16848010
]
Lars Hofhansl commented on PHOENIX-5112:
----------------------------------------
Hmm:
{code:java}
[INFO] Running
org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec
[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.469 s
<<< FAILURE! - in
org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec
[ERROR]
testGeneratedIndexUpdates(org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec)
Time elapsed: 0.207 s <<< FAILURE!
java.lang.AssertionError: Had some index updates, though it should have been
covered by the delete
at
org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec.ensureNoUpdatesWhenCoveredByDelete(TestCoveredColumnIndexCodec.java:242)
at
org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec.testGeneratedIndexUpdates(TestCoveredColumnIndexCodec.java:220)
{code}
Why didn't precommit fail with this?!
Will look for a few, if I cannot fix it, I'll revert.
> Simplify QueryPlan selection in Phoenix.
> ----------------------------------------
>
> Key: PHOENIX-5112
> URL: https://issues.apache.org/jira/browse/PHOENIX-5112
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: 5112-master.txt, 5112-master.txt
>
>
> Brought to light in part in PHOENIX-5109, plan selection in Phoenix is too
> complicated with its logic spread over multiple areas. My recent changes let
> most index through the initial filters and next step is to put all the logic
> in {{QueryOptimizer.orderPlansBestToWorst}}.
> One exception is plans with global indexes for queries with uncovered
> queries, those should still be handled in {{addPlan}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
