[ 
https://issues.apache.org/jira/browse/PHOENIX-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863466#comment-16863466
 ] 

Chinmay Kulkarni commented on PHOENIX-5343:
-------------------------------------------

[~kozdemir] nothing stops an end-user from creating a view on a SYSTEM table 
and perhaps this may be used by some clients (for whatever reasons). Perhaps we 
should account for those scenarios as well?

In general, we could just change the condition to
{code:java}
TABLE_TYPE != PTableType.VIEW.getSerializedValue() AND TABLE_TYPE != 
PTableType.INDEX.getSerializedValue()
{code}
This is also more consistent with the Jira description.

> OrphanViewTool should not check Index Tables
> --------------------------------------------
>
>                 Key: PHOENIX-5343
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5343
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.14.0, 5.0.0, 4.15.0
>            Reporter: Kadir OZDEMIR
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0, 4.14.3
>
>         Attachments: PHOENIX-5343.master.001.patch
>
>
> OrphanViewTool checks the integrity of a view tree rooted at a table. The set 
> of candidate root tables should not include Index Tables. OrphanViewTool 
> should only consider tables of type PTableType.TABLE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to