[
https://issues.apache.org/jira/browse/PHOENIX-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863596#comment-16863596
]
Hadoop QA commented on PHOENIX-5343:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12971732/PHOENIX-5343.master.002.patch
against master branch at commit 2fe8d5b65219941d65107afc44d803abe9ca8b87.
ATTACHMENT ID: 12971732
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private void createBaseTableIndexAndViews(Connection
baseTableConnection, String baseTableFullName,
+ String grandchildViewSchemaName,
String grandGrandChildViewSchemaName)
+ createBaseTableIndexAndViews(connection, baseTableFullName,
viewConnection, SCHEMA2, SCHEMA3, SCHEMA4);
+ createBaseTableIndexAndViews(connection, baseTableFullName,
viewConnection, SCHEMA2, SCHEMA2, SCHEMA2);
+ createBaseTableIndexAndViews(connection, baseTableFullName,
viewConnection, null, SCHEMA3, SCHEMA3);
+ createBaseTableIndexAndViews(connection, baseTableFullName,
viewConnection, SCHEMA2, SCHEMA3, null);
+ createBaseTableIndexAndViews(connection, baseTableFullName,
viewConnection, SCHEMA2, SCHEMA3, SCHEMA4);
+ createBaseTableIndexAndViews(connection, baseTableFullName,
viewConnection, SCHEMA2, SCHEMA3, SCHEMA4);
+ createBaseTableIndexAndViews(connection, baseTableFullName,
viewConnection, SCHEMA2, SCHEMA3, SCHEMA3);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.SaltedIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2672//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2672//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2672//console
This message is automatically generated.
> OrphanViewTool should not check Index Tables
> --------------------------------------------
>
> Key: PHOENIX-5343
> URL: https://issues.apache.org/jira/browse/PHOENIX-5343
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.14.0, 5.0.0, 4.15.0
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Major
> Fix For: 4.15.0, 5.1.0, 4.14.3
>
> Attachments: PHOENIX-5343.master.001.patch,
> PHOENIX-5343.master.002.patch
>
>
> OrphanViewTool checks the integrity of a view tree rooted at a table. The set
> of candidate root tables should not include Index Tables. OrphanViewTool
> should only consider tables of type PTableType.TABLE.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
