BinShi-SecularBird commented on a change in pull request #482: PHOENIX-4925 Use
a Variant Segment tree to organize Guide Post Info
URL: https://github.com/apache/phoenix/pull/482#discussion_r298715818
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java
##########
@@ -342,8 +343,10 @@ public Scan intersectScan(Scan scan, final byte[]
originalStartKey, final byte[]
// TODO: it seems that our SkipScanFilter or HBase runs into
problems if we don't
// have an enclosing range when we do a point lookup.
if (isPointLookup) {
- scanStartKey = ScanUtil.getMinKey(schema,
newSkipScanFilter.getSlots(), slotSpan);
- scanStopKey = ScanUtil.getMaxKey(schema,
newSkipScanFilter.getSlots(), slotSpan);
+ scanStartKey = ScanUtil.getMinKey(
+ newSkipScanFilter.getSchema(),
newSkipScanFilter.getSlots(), newSkipScanFilter.getSlotSpan());
Review comment:
When the PK column type is varchar, the column is translated to multiple
char[1] columns in SkipScanFilter's schema, and the SkipScanFilter's schema is
supposed to use here, otherwise it will cause the test failures in
SkipScanFilterIntersectTest.java.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
