BinShi-SecularBird commented on a change in pull request #482: PHOENIX-4925 Use
a Variant Segment tree to organize Guide Post Info
URL: https://github.com/apache/phoenix/pull/482#discussion_r298717209
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/DefaultGuidePostsCacheFactory.java
##########
@@ -29,11 +28,15 @@ public PhoenixStatsLoader
getPhoenixStatsLoader(ConnectionQueryServices querySer
Preconditions.checkNotNull(config);
final boolean isStatsEnabled =
config.getBoolean(STATS_COLLECTION_ENABLED, DEFAULT_STATS_COLLECTION_ENABLED);
- if (queryServices == null || !isStatsEnabled) {
+ if (queryServices == null || ! isStatsEnabled) {
Review comment:
I always add an extra space between ! and the variable for better readness.
I saw the other places use this coding style too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
