[ 
https://issues.apache.org/jira/browse/PHOENIX-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16880982#comment-16880982
 ] 

Hadoop QA commented on PHOENIX-5333:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12974004/PHOENIX-5333.master.v6.patch
  against master branch at commit 3fea4c3ebc69edaff3de19db0fcdb392a90360f4.
  ATTACHMENT ID: 12974004

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +    private static final String [] INDEXES_LIST_NAMESPACE = 
{"TEST:INDEX1", "TEST:INDEX2", "TEST1:INDEX3",
+    private void checkNewIndexingCoprocessors(String [] indexList, String [] 
tableList) throws IOException {
+    private void checkOldIndexingCoprocessors(String [] indexList, String [] 
tableList) throws IOException {
+    public ParameterizedIndexUpgradeToolIT(boolean mutable, boolean upgrade, 
boolean isNamespaceEnabled) {
+            "[Optional]Whether or not synchronously rebuild the indexes; 
default rebuild asynchronous");
+            addCoprocessor(admin, tableName,  tableDescBuilder, 
IndexRegionObserver.class.getName());
+            removeCoprocessor(admin, tableName,  tableDescBuilder, 
IndexRegionObserver.class.getName());
+    private void addCoprocessor(Admin admin, String tableName, 
TableDescriptorBuilder tableDescBuilder, String coprocName) throws IOException {
+    private void removeCoprocessor(Admin admin, String tableName, 
TableDescriptorBuilder tableDescBuilder, String coprocName) throws IOException {
+                addCoprocessor(admin, indexName, indexTableDescBuilder, 
GlobalIndexChecker.class.getName());

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2743//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2743//console

This message is automatically generated.

> A tool to upgrade existing tables/indexes to use self-consistent global 
> indexes design
> --------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5333
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5333
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Swaroopa Kadam
>            Assignee: Swaroopa Kadam
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0, 4.14.3
>
>         Attachments: PHOENIX-5333.master.v1.patch, 
> PHOENIX-5333.master.v2.patch, PHOENIX-5333.master.v3.patch, 
> PHOENIX-5333.master.v4.patch, PHOENIX-5333.master.v5.patch, 
> PHOENIX-5333.master.v6.patch
>
>          Time Spent: 19h 50m
>  Remaining Estimate: 0h
>
> A tool to upgrade existing tables/indexes to use self-consistent global 
> indexes design in PHOENIX-5156



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to