[
https://issues.apache.org/jira/browse/PHOENIX-4878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891710#comment-16891710
]
Hadoop QA commented on PHOENIX-4878:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12975578/PHOENIX-4878-4.x-HBase-1.3.patch
against 4.x-HBase-1.3 branch at commit
b4d403798eb8fdf748d8fb9c13b62bd0891317e7.
ATTACHMENT ID: 12975578
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ int clientVersion,
List<PTable> sharedPTablesToDelete)
+ if (result.getSharedPTablesToDelete() != null &&
!result.getSharedPTablesToDelete().isEmpty())
+ new java.lang.String[] { "ReturnCode", "MutationTime", "Table",
"TablesToDelete", "ColumnName", "FamilyName", "FunctionName", "Function",
"SharedTablesToDelete", "Schema", "AutoPartitionNum", "ViewIndexId",
"ViewIndexIdType", "SharedPTablesToDelete", });
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.DropColumnIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TenantSpecificViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2833//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2833//console
This message is automatically generated.
> Remove SharedTableState and replace with PTable
> -----------------------------------------------
>
> Key: PHOENIX-4878
> URL: https://issues.apache.org/jira/browse/PHOENIX-4878
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Thomas D'Silva
> Assignee: Xinyi Yan
> Priority: Major
> Attachments: PHOENIX-4878-4.x-HBase-1.3.patch, PHOENIX-4878.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When we drop a column from a base table we also drop view indexes that
> require the column. This information is passed back to the client using the
> SharedTableState proto. Convert this to use our regular PTable proto.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
