[ https://issues.apache.org/jira/browse/PHOENIX-4878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907756#comment-16907756 ]
Hadoop QA commented on PHOENIX-4878: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12977662/PHOENIX-4878.v3-master.patch against master branch at commit ffcffb031fa9da661dccae48b94366ddb6238b3f. ATTACHMENT ID: 12977662 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 release audit{color}. The applied patch generated 1 release audit warnings (more than the master's current 0 warnings). {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + PTableType.fromSerializedValue(tableType), tableMetadata, childLinkMutations, + List<Mutation> childLinkMutations, List<ImmutableBytesPtr> invalidateList, List<byte[]> tableNamesToDelete, + int clientVersion, List<PTable> sharedPTablesToDelete) + if (result.getSharedPTablesToDelete() != null && !result.getSharedPTablesToDelete().isEmpty()) + new java.lang.String[] { "ReturnCode", "MutationTime", "Table", "TablesToDelete", "ColumnName", "FamilyName", "FunctionName", "Function", "SharedTablesToDelete", "Schema", "AutoPartitionNum", "ViewIndexId", "ViewIndexIdType", "SharedPTablesToDelete", }); {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterTableWithViewsIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2911//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2911//artifact/patchprocess/patchReleaseAuditWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2911//console This message is automatically generated. > Remove SharedTableState and replace with PTable > ----------------------------------------------- > > Key: PHOENIX-4878 > URL: https://issues.apache.org/jira/browse/PHOENIX-4878 > Project: Phoenix > Issue Type: Improvement > Reporter: Thomas D'Silva > Assignee: Xinyi Yan > Priority: Major > Attachments: PHOENIX-4878.v2-4.x-HBase-1.3.patch, > PHOENIX-4878.v2-master.patch, PHOENIX-4878.v3-master.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > When we drop a column from a base table we also drop view indexes that > require the column. This information is passed back to the client using the > SharedTableState proto. Convert this to use our regular PTable proto. -- This message was sent by Atlassian JIRA (v7.6.14#76016)