ChinmaySKulkarni commented on a change in pull request #569: PHOENIX-4743:
ALTER TABLE ADD COLUMN for global index should not modify HBase metadata if
failed
URL: https://github.com/apache/phoenix/pull/569#discussion_r316936748
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java
##########
@@ -852,6 +854,37 @@ public void testDropMultipleColumns() throws Exception {
conn1.close();
}
+ @Test
+ public void testAlterTableOnGlobalIndex() throws Exception {
+ try (Connection conn = DriverManager.getConnection(getUrl())) {
+ conn.setAutoCommit(false);
+ Statement stmt = conn.createStatement();
+ String tableName = generateUniqueName();
+ String globalIndexTableName = generateUniqueName();
+
+ stmt.execute("CREATE TABLE " + tableName + "(k VARCHAR PRIMARY
KEY, v1 VARCHAR, v2 VARCHAR)");
+ stmt.execute("DROP TABLE " + tableName);
Review comment:
Why do we need to execute these create and drop table statements?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
