ChinmaySKulkarni commented on a change in pull request #569: PHOENIX-4743:
ALTER TABLE ADD COLUMN for global index should not modify HBase metadata if
failed
URL: https://github.com/apache/phoenix/pull/569#discussion_r316938576
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -2127,6 +2124,13 @@ public MetaDataResponse call(MetaDataService instance)
throws IOException {
}
}
}
+ else if (result.getMutationCode() ==
MutationCode.UNALLOWED_TABLE_MUTATION) {
Review comment:
We can combine this check and the bottom `if` condition:
```java
if (modifyHTable && result.getMutationCode() !=
MutationCode.UNALLOWED_TABLE_MUTATION) {
sendHBaseMetaData(tableDescriptors, pollingNeeded);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
