[
https://issues.apache.org/jira/browse/PHOENIX-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945254#comment-16945254
]
Daniel Wong commented on PHOENIX-5510:
--------------------------------------
So thinking about this a bit more this may not be an actual bug in logging the
result metrics as users should close resultsets and statements prior to
connections. However, it would be nice to log something in case this does
occur so administrators etc can have info on when end users do not properly
handle this type of closing.
PhoenixMetricsLog interface could have an additional method either in the next
release or if move to java 8 occurs and can use a default method. In addition
this code could be gutted out and moved to a separate client utils library.
Perhaps even better a cleaner java service implementation with better coupling
with the internal phoenix code.
Note for future readers: for my own use case I will inherit and override the
logging classes to handle logging and metrics for this case.
FYI
[~tdsilva] [~ckulkarni]
> LoggingPhoenixConnection on close does not log with unclosed
> statements/result sets
> -----------------------------------------------------------------------------------
>
> Key: PHOENIX-5510
> URL: https://issues.apache.org/jira/browse/PHOENIX-5510
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.1, 4.14.3
> Reporter: Daniel Wong
> Priority: Minor
>
> Testing the LoggingPhoenixConnection it does not handle request level metrics
> for unclosed statements/result sets. This is due to the delegate nature
> where the resulting PhoenixConnection ends up closing these without ever
> going through a delegate. Without this log or an way to inform the user that
> these occurred operations are essentially blind to these requests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
