[
https://issues.apache.org/jira/browse/PHOENIX-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946126#comment-16946126
]
Chinmay Kulkarni commented on PHOENIX-5510:
-------------------------------------------
[~dbwong] I think it is fair to assume that the user should close resultset and
statement objects before they close the underlying connection. I am +1 to
adding additional logging to indicate this. The main issue seems to be tying
the connection to the statements executed and the underlying SQL.
I haven't looked into this in a lot of detail, but is there currently a metric
that accounts for open statements and resultsets? We can tie that in with the
open connection and on close, check the values for these metrics and log error
accordingly.
> LoggingPhoenixConnection on close does not log with unclosed
> statements/result sets
> -----------------------------------------------------------------------------------
>
> Key: PHOENIX-5510
> URL: https://issues.apache.org/jira/browse/PHOENIX-5510
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.1, 4.14.3
> Reporter: Daniel Wong
> Priority: Minor
>
> Testing the LoggingPhoenixConnection it does not handle request level metrics
> for unclosed statements/result sets. This is due to the delegate nature
> where the resulting PhoenixConnection ends up closing these without ever
> going through a delegate. Without this log or an way to inform the user that
> these occurred operations are essentially blind to these requests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
