gjacoby126 commented on a change in pull request #597: PHOENIX-5522 If index is
disabled, IndexUpgradeTool should not fail d…
URL: https://github.com/apache/phoenix/pull/597#discussion_r334202179
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
##########
@@ -491,6 +491,15 @@ private int rebuildIndexes(String dataTable, IndexTool
indexingTool) {
try {
LOGGER.info("Rebuilding index: " + String.join(",", args));
if (!dryRun) {
+ // If the index is in DISABLED state, indexTool will fail.
First to ALTER REBUILD ASYNC
Review comment:
nit: Good for the comment to make clear that ALTER INDEX REBUILD ASYNC will
set the index state to BUILDING, which is safe to make ACTIVE later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
