gjacoby126 commented on a change in pull request #597: PHOENIX-5522 If index is
disabled, IndexUpgradeTool should not fail d…
URL: https://github.com/apache/phoenix/pull/597#discussion_r334202300
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java
##########
@@ -221,25 +235,25 @@ private void checkOldIndexingCoprocessors(String []
indexList, String [] tableLi
}
}
- @Parameters(name
="IndexUpgradeToolIT_mutable={0},upgrade={1},isNamespaceEnabled={2}")
+ @Parameters(name
="IndexUpgradeToolIT_mutable={0},upgrade={1},isNamespaceEnabled={2},isDisabledIndex={3}")
public static Collection<Object[]> data() {
- return Arrays.asList(new Object[][] {
- {false, false, true},
- {true, false, true},
- {false, true, true},
- {true, true, true},
- {false, false, false},
- {true, false, false},
- {false, true, false},
- {true, true, false}
- });
+ return Arrays.asList(new Object[][] { { false, false, true, true },
+ { false, false, true, false }, { true, false, true, true },
Review comment:
how long do all of these take to run now? Are there combinations that are
redundant (or orthogonal and can be tested by a single test)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
