yanxinyi commented on a change in pull request #599: Create columns in SYSCAT
and fields in PTable.proto for view TTL support
URL: https://github.com/apache/phoenix/pull/599#discussion_r336689492
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##########
@@ -311,8 +313,10 @@
IMMUTABLE_STORAGE_SCHEME + "," +
ENCODING_SCHEME + "," +
USE_STATS_FOR_PARALLELIZATION +"," +
- VIEW_INDEX_ID_DATA_TYPE +
- ") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)";
+ VIEW_INDEX_ID_DATA_TYPE +"," +
Review comment:
I don't understand the logic of adding a new column to SYSTEM.CATALOG table.
for the server-side update, do we drop the table and re-create a table?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
