yanxinyi commented on a change in pull request #599: Create columns in SYSCAT 
and fields in PTable.proto for view TTL support
URL: https://github.com/apache/phoenix/pull/599#discussion_r342295511
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewTTLIT.java
 ##########
 @@ -87,6 +99,27 @@ private void 
assertViewHeaderRowsHaveViewTTLRelatedCells(String schemaName, long
 
     }
 
+    private void assertSyscatHaveViewTTLRelatedColumns(String tenantId, String 
schemaName, String tableName, String tableType, long ttlValueExpected)
 
 Review comment:
   nit: more than 100 char per line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to