BinShi-SecularBird commented on a change in pull request #605: PHOENIX-5540
Full row index write at the last write phase for immutab…
URL: https://github.com/apache/phoenix/pull/605#discussion_r339243284
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java
##########
@@ -506,7 +506,7 @@ private void populatePendingRows(BatchMutateContext
context, long now) {
return mutations;
}
- public void removeEmptyColumn(Mutation m, byte[] emptyCF, byte[] emptyCQ) {
+ public static void removeEmptyColumn(Mutation m, byte[] emptyCF, byte[]
emptyCQ) {
Review comment:
@gokceni, @kadirozde, IMPO, we should move the following list from
IndexRegionObserver to an MutationUtil class in
org.apache.phoenix.hbase.index.util or org.apache.phoenix.util:
IndexRegionObserver.UNVERIFIED_BYTES
IndexRegionObserver.VERIFIED_BYTES
IndexRegionObserver.getMaxTimestamp(...)
IndexRegionObserver.removeEmptyColumn(...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
