[
https://issues.apache.org/jira/browse/PHOENIX-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961844#comment-16961844
]
Hadoop QA commented on PHOENIX-5527:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12984230/PHOENIX-5527.master.004.patch
against master branch at commit 6ce24abf310ff1d0fb8976a02be5758a6d311ab2.
ATTACHMENT ID: 12984230
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ unverifiedPut.addColumn(emptyCF, emptyCQ,
timestamp - 1, IndexRegionObserver.UNVERIFIED_BYTES);
+ // Sleep for one millisecond if we have done the data table updates
in less than 1 ms. The sleep is necessary
+ // not to allow another data table write on the same row within the
same ms. The sleep is very rare to happen.
+ // Assume that a data table write completes at timestamp t. Now
assume another write happens on the same data
+ // row at timestamp t+1. The mutation for unverifying the index
table row(s) for the previous write will have
+ // timestamp t. If this happens before the last phase of the first
write (with timestamp t) completes, then
+ // the index row(s) for the first write will have the verified
status. We do not want this to happen as the
+ // updates for the first write are supposed to be overwritten
(unverified) by the second write.
+ if (!context.rowLocks.isEmpty() && context.dataWriteStartTime ==
EnvironmentEdgeManager.currentTimeMillis()) {
+ LOG.debug("After data write, slept 1ms for " +
c.getEnvironment().getRegion().getRegionInfo().getTable().getNameAsString());
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.SortMergeJoinNoIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.schema.stats.TxStatsCollectorIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3076//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3076//console
This message is automatically generated.
> Unverified index rows should not be deleted due to replication lag
> -------------------------------------------------------------------
>
> Key: PHOENIX-5527
> URL: https://issues.apache.org/jira/browse/PHOENIX-5527
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.14.3
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-5527.master.001.patch,
> PHOENIX-5527.master.002.patch, PHOENIX-5527.master.003.patch,
> PHOENIX-5527.master.004.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The current default delete time for unverified index rows is 10 minutes. If
> an index table row is replicated before its data table row and the
> replication row is unverified at the time of replication, it can be deleted
> when it is scanned on the destination cluster. To prevent these deletes due
> to replication lag issues, we should increase the default time to 7 days.
> This value is configurable using the configuration parameter,
> phoenix.global.index.row.age.threshold.to.delete.ms.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
