[ 
https://issues.apache.org/jira/browse/PHOENIX-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957537#comment-16957537
 ] 

Lars Hofhansl commented on PHOENIX-5527:
----------------------------------------

I agree with the explanation.

What I will say is that I'm getting a bit more concerned about the complexity 
and potential brittleness of this. Mucking with TSs and backdating them can 
easily lead to hard-to-track issues.

It is what it is... Let's just make sure we have great test coverage for this 
and we test the heck out of this with concurrent updates and flushes and 
compaction, and test with read-repair metrics rather than just for correctness. 
We do have an HBase test - TestAtomicOperation -  that does this sort of thing 
perhaps we can steal from that, it just hammers the mini cluster with updates 
and locks and all-the-while performs flushes and compactions.

(As an aside: I can't help but pointing out that my favored solution was to 
completely remove the current global mutable and immutable indexing code and 
_only_ support local indexes and fully transactional global indexes with 
external transaction managers such as Omid and/or Tephra, all of which already 
exist. Anyway... Just an aside. Let's finish this one.)


> Unverified index rows should not be deleted due to replication lag 
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-5527
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5527
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 5.0.0, 4.14.3
>            Reporter: Kadir OZDEMIR
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: PHOENIX-5527.master.001.patch, 
> PHOENIX-5527.master.002.patch, PHOENIX-5527.master.003.patch
>
>
> The current default delete time for unverified index rows is 10 minutes. If 
> an index table row is replicated before its data table row and the 
> replication row is unverified at the time of replication, it can be deleted 
> when it is scanned on the destination cluster. To prevent these deletes due 
> to replication lag issues, we should increase the default time to 7 days. 
> This value is configurable using the configuration parameter,  
> phoenix.global.index.row.age.threshold.to.delete.ms.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to