gjacoby126 commented on a change in pull request #629: PHOENIX-5559 Fix
remaining issues with Long viewIndexIds.
URL: https://github.com/apache/phoenix/pull/629#discussion_r345478206
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/UpgradeIT.java
##########
@@ -188,7 +188,7 @@ public void testMapTableToNamespaceDuringUpgrade()
PName physicalName = PNameFactory.newName(hbaseTableName);
String newSchemaName =
MetaDataUtil.getViewIndexSequenceSchemaName(physicalName, true);
String newSequenceName =
MetaDataUtil.getViewIndexSequenceName(physicalName, tenantId, true);
- verifySequenceValue(null, newSequenceName, newSchemaName,
-9223372036854775805L);
+ verifySequenceValue(null, newSequenceName, newSchemaName, -32765);
Review comment:
nit: can we put this in terms of Short.MIN_VALUE to make the logic clearer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
