gjacoby126 commented on a change in pull request #629: PHOENIX-5559 Fix
remaining issues with Long viewIndexIds.
URL: https://github.com/apache/phoenix/pull/629#discussion_r345492108
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java
##########
@@ -941,6 +941,16 @@ public static IndexType getIndexType(List<Mutation>
tableMetaData, KeyValueBuild
return null;
}
+ public static PDataType<?> getIndexDataType(List<Mutation> tableMetaData,
+ KeyValueBuilder builder, ImmutableBytesWritable value) {
+ if (getMutationValue(getPutOnlyTableHeaderRow(tableMetaData),
Review comment:
nit: comment would be really nice here. I _think_ you're looking up the view
index id config setting from syscat, and that makes sense, but the code's a
mouthful without explanation :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
