ChinmaySKulkarni commented on a change in pull request #599: Create columns in
SYSCAT and fields in PTable.proto for view TTL support
URL: https://github.com/apache/phoenix/pull/599#discussion_r345969298
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##########
@@ -311,8 +313,10 @@
IMMUTABLE_STORAGE_SCHEME + "," +
ENCODING_SCHEME + "," +
USE_STATS_FOR_PARALLELIZATION +"," +
- VIEW_INDEX_ID_DATA_TYPE +
- ") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)";
+ VIEW_INDEX_ID_DATA_TYPE +"," +
Review comment:
OR, we will need to create a new tool like the IndexUpgradeTool to do the
same syscat table alteration in order to enable using this feature for a patch
upgrade i.e. 4.x.y -> 4.x.(y+1)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
