ChinmaySKulkarni commented on a change in pull request #599: Create columns in
SYSCAT and fields in PTable.proto for view TTL support
URL: https://github.com/apache/phoenix/pull/599#discussion_r350972919
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/TableProperty.java
##########
@@ -222,6 +224,28 @@ public Object getValue(Object value) {
public Object getPTableValue(PTable table) {
return table.useStatsForParallelization();
}
+ },
+
+ VIEW_TTL(PhoenixDatabaseMetaData.VIEW_TTL, true, true, true) {
+ @Override
+ public Object getValue(Object value) {
+ if (value instanceof String) {
+ String strValue = (String) value;
+ if ("FOREVER".equalsIgnoreCase(strValue)) {
+ return HConstants.LATEST_TIMESTAMP;
+ } else if ("NONE".equalsIgnoreCase(strValue)) {
Review comment:
@jpisaac What about passing in zero as viewTTL? What would that mean? Would
it have any meaning at all or some special meaning?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
