[
https://issues.apache.org/jira/browse/PHOENIX-5432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976910#comment-16976910
]
Hadoop QA commented on PHOENIX-5432:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12986149/PHOENIX-5432.master.v5.patch
against master branch at commit 234660ea0082815c59704a61dc9c33bb11d64381.
ATTACHMENT ID: 12986149
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 130
new or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ dv == null ? null : new
LiteralExpression.Builder().setValue(((LiteralParseNode)dv).getValue()).buildValueAndDeterminism(false),
+ minv == null ? null : new
LiteralExpression.Builder().setValue(((LiteralParseNode)minv).getValue()).buildValueAndDeterminism(false),
+ maxv == null ? null : new
LiteralExpression.Builder().setValue(((LiteralParseNode)maxv).getValue()).buildValueAndDeterminism(false));})
+ private static final Expression NOT_NULL_STRING = new
LiteralExpression.Builder().setValue(PVarchar.INSTANCE.toObject(KeyRange.IS_NOT_NULL_RANGE.getLowerRange())).buildValueAndDeterminism(false);
+ return new
LiteralExpression.Builder().setValue(false).setDeterminism(determinism).buildValueAndDeterminism(false);
+ return new
LiteralExpression.Builder().setValue(value).setDeterminism(Determinism.ALWAYS).build();
+ return new
LiteralExpression.Builder().setValue(node.getValue()).setDataType(node.getType()).setDeterminism(Determinism.ALWAYS).build();
+ return new
LiteralExpression.Builder().setDataType(PBoolean.INSTANCE).setDeterminism(rhs.getDeterminism()).build();
+ return new
LiteralExpression.Builder().setValue(false).setDeterminism(rhs.getDeterminism()).buildValueAndDeterminism(false);
+ rhs = new
LiteralExpression.Builder().setValue(rhsLiteral).setDataType(PChar.INSTANCE)
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.LikeExpressionIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3144//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3144//console
This message is automatically generated.
> Refactor LiteralExpression to use the builder pattern
> -----------------------------------------------------
>
> Key: PHOENIX-5432
> URL: https://issues.apache.org/jira/browse/PHOENIX-5432
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Chinmay Kulkarni
> Assignee: Christine Feng
> Priority: Major
> Attachments: PHOENIX-5432-master-v1.patch,
> PHOENIX-5432.master.v2.patch, PHOENIX-5432.master.v3.patch,
> PHOENIX-5432.master.v4.patch, PHOENIX-5432.master.v5.patch, PHOENIX-5432.patch
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> LiteralExpression is a mess. While it provides newConstant() APIs to build
> the object, it also provides two public constructors. There are 10 overloaded
> newConstant() methods and it is unclear which API to use in which case.
> This should be refactored to use the builder pattern and final member
> variables. Ideally, getters such as getMaxLength() should be simple member
> variable accessors and other ad-hoc logic surrounding those variables should
> be handled correctly when setting their respective values.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
