[
https://issues.apache.org/jira/browse/PHOENIX-5432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982948#comment-16982948
]
Hadoop QA commented on PHOENIX-5432:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12986841/PHOENIX-5432.master.v8.patch
against master branch at commit cdabf29aa7440c4a8b8c85b81542121ffcb7baac.
ATTACHMENT ID: 12986841
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 140
new or modified tests.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail .
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/target/generated-sources/antlr3/org/apache/phoenix/parse/PhoenixSQLParser.java:[10384,136]
unreported exception java.sql.SQLException; must be caught or declared to be
thrown
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/target/generated-sources/antlr3/org/apache/phoenix/parse/PhoenixSQLParser.java:[10385,136]
unreported exception java.sql.SQLException; must be caught or declared to be
thrown
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/target/generated-sources/antlr3/org/apache/phoenix/parse/PhoenixSQLParser.java:[10386,136]
unreported exception java.sql.SQLException; must be caught or declared to be
thrown
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile)
on project phoenix-core: Compilation failure: Compilation failure:
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/target/generated-sources/antlr3/org/apache/phoenix/parse/PhoenixSQLParser.java:[10384,136]
unreported exception java.sql.SQLException; must be caught or declared to be
thrown
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/target/generated-sources/antlr3/org/apache/phoenix/parse/PhoenixSQLParser.java:[10385,136]
unreported exception java.sql.SQLException; must be caught or declared to be
thrown
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/target/generated-sources/antlr3/org/apache/phoenix/parse/PhoenixSQLParser.java:[10386,136]
unreported exception java.sql.SQLException; must be caught or declared to be
thrown
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :phoenix-core
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3158//console
This message is automatically generated.
> Refactor LiteralExpression to use the builder pattern
> -----------------------------------------------------
>
> Key: PHOENIX-5432
> URL: https://issues.apache.org/jira/browse/PHOENIX-5432
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Chinmay Kulkarni
> Assignee: Christine Feng
> Priority: Major
> Attachments: PHOENIX-5432-master-v1.patch,
> PHOENIX-5432.master.v2.patch, PHOENIX-5432.master.v3.patch,
> PHOENIX-5432.master.v4.patch, PHOENIX-5432.master.v5.patch,
> PHOENIX-5432.master.v6.patch, PHOENIX-5432.master.v7.patch,
> PHOENIX-5432.master.v8.patch, PHOENIX-5432.patch
>
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> LiteralExpression is a mess. While it provides newConstant() APIs to build
> the object, it also provides two public constructors. There are 10 overloaded
> newConstant() methods and it is unclear which API to use in which case.
> This should be refactored to use the builder pattern and final member
> variables. Ideally, getters such as getMaxLength() should be simple member
> variable accessors and other ad-hoc logic surrounding those variables should
> be handled correctly when setting their respective values.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
