ChinmaySKulkarni commented on a change in pull request #616: PHOENIX-5432: Refactor LiteralExpression to use the builder pattern URL: https://github.com/apache/phoenix/pull/616#discussion_r347669321
########## File path: phoenix-core/src/main/java/org/apache/phoenix/expression/LiteralExpression.java ########## @@ -34,14 +34,13 @@ import org.apache.phoenix.schema.types.PBoolean; import org.apache.phoenix.schema.types.PChar; import org.apache.phoenix.schema.types.PDataType; -import org.apache.phoenix.schema.types.PDate; -import org.apache.phoenix.schema.types.PTime; import org.apache.phoenix.schema.types.PTimestamp; import org.apache.phoenix.schema.types.PVarchar; import org.apache.phoenix.schema.types.PhoenixArray; import org.apache.phoenix.util.ByteUtil; import org.apache.phoenix.util.StringUtil; + import com.google.common.base.Preconditions; Review comment: nit: remove extra line ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
