[
https://issues.apache.org/jira/browse/PHOENIX-5590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993006#comment-16993006
]
Hadoop QA commented on PHOENIX-5590:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12988457/PHOENIX-5590.4.x-HBase-1.4.001.patch
against 4.x-HBase-1.4 branch at commit
964dd80f20ab8649af7672314f4127b73c0280b7.
ATTACHMENT ID: 12988457
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ "This parameter is deprecated. Direct mode will be used
whether it is set or not. Keeping it for backwards compatibility.");
+ if (!cmdLine.hasOption(PARTIAL_REBUILD_OPTION.getOpt()) &&
!cmdLine.hasOption(INDEX_TABLE_OPTION.getOpt())) {
+ throw new IllegalStateException("Index name should be passed
unless it is a partial rebuild.");
+ boolean useSnapshot, String tenantId, boolean disableBefore,
boolean shouldDeleteBeforeRebuild, boolean runForeground) throws Exception {
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3177//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3177//console
This message is automatically generated.
> IndexTool without -direct option doesn't work with consistent index design.
> Make -direct mandatory
> --------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-5590
> URL: https://issues.apache.org/jira/browse/PHOENIX-5590
> Project: Phoenix
> Issue Type: Bug
> Reporter: Gokcen Iskender
> Assignee: Gokcen Iskender
> Priority: Major
> Attachments: PHOENIX-5590.4-x.001.patch,
> PHOENIX-5590.4.x-HBase-1.4.001.patch, PHOENIX-5590.master.001.patch,
> PHOENIX-5590.master.002.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
