yanxinyi commented on a change in pull request #665: PHOENIX-5650:
IndexUpgradeTool does not rebuild view indexes
URL: https://github.com/apache/phoenix/pull/665#discussion_r361509977
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java
##########
@@ -346,6 +358,26 @@ public void testDryRunAndFailures() throws Exception {
}
}
+ @Test
+ public void verifyViewAndViewIndexes() throws SQLException {
+ ResultSet rs = conn.createStatement().executeQuery(VIEWS_QUERY);
+ int countViews = -1, indexCount = -1;
+ while(rs.next()) {
Review comment:
nit: `if (rs.next())` is better? We technically can't go there more than 1
once, since we just `SELECT COUNT`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
