gjacoby126 commented on a change in pull request #665: PHOENIX-5650:
IndexUpgradeTool does not rebuild view indexes
URL: https://github.com/apache/phoenix/pull/665#discussion_r362966203
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
##########
@@ -648,17 +648,18 @@ private boolean
extractTablesAndIndexes(PhoenixConnection conn) {
}
if (hasViewIndex) {
- String viewSql = "SELECT DISTINCT TABLE_NAME, TENANT_ID FROM "
- + "SYSTEM.CATALOG "
- + "WHERE COLUMN_FAMILY = \'" + dataTableFullName + "\' "
+ String viewSql = "SELECT DISTINCT COLUMN_FAMILY, TENANT_ID FROM "
Review comment:
can this be extracted into a reusable function that verifyViewAndViewIndexes
can also use? Right now the test is verifying that its _own_ query works as
expected, but not the actual upgrade tool's. Imagine if someone changed
IndexUpgradeTool:651 and broke it -- the test would still pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
