swaroopak commented on a change in pull request #666: Phoenix-5652 Improve
IndexScrutinyTool perf by using SkipScan in index table queries
URL: https://github.com/apache/phoenix/pull/666#discussion_r361732655
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/IndexColumnNames.java
##########
@@ -252,4 +288,61 @@ public String getQualifiedIndexTableName() {
public List<String> getIndexPkColNames() {
return indexPkColNames;
}
+
+ public List<String> getDataColNamesForSkipScan() {
+ if (pdataTable.isMultiTenant()) {
+ return dataColNames;
+ } else {
+ return dataColNamesForSkipScan;
+ }
+ // return dataColNamesForSkipScan;
+ }
+
+ public List<String> getIndexPkColNamesForSkipScan() {
+ if (pdataTable.isMultiTenant()) {
+ return indexPkColNames;
+ } else {
+ return indexPkColNamesForSkipScan;
+ }
+ // return indexPkColNamesForSkipScan;
Review comment:
nit: please remove the commented code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
