swaroopak commented on a change in pull request #666: Phoenix-5652 Improve 
IndexScrutinyTool perf by using SkipScan in index table queries
URL: https://github.com/apache/phoenix/pull/666#discussion_r361742134
 
 

 ##########
 File path: 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/IndexColumnNames.java
 ##########
 @@ -79,6 +85,8 @@ public IndexColumnNames(final PTable pdataTable, final 
PTable pindexTable) {
                 dataColSqlTypeNames.add(getDataTypeString(dPkCol));
                 indexPkColNames.add(indexColumnName);
                 indexColSqlTypeNames.add(getDataTypeString(indexCol));
+                indexColSqlTypeNamesForSkipScan.put(indexColumnName, 
getDataTypeString(dPkCol));
 
 Review comment:
   Is using skipscan for indexscrutiny optional? If not, can the above two 
lists be merged into?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to