priyankporwal commented on a change in pull request #665: PHOENIX-5650:
IndexUpgradeTool does not rebuild view indexes
URL: https://github.com/apache/phoenix/pull/665#discussion_r363509403
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
##########
@@ -692,6 +692,17 @@ private boolean extractTablesAndIndexes(PhoenixConnection
conn) {
return viewIndexes;
}
+ @VisibleForTesting
+ public String getViewIndexesSql(String viewName, String schemaName, String
tenantId) {
+ return "SELECT DISTINCT COLUMN_FAMILY FROM "
+ + "SYSTEM.CATALOG "
+ + "WHERE TABLE_NAME = \'" + viewName + "\'"
+ + (!StringUtil.EMPTY_STRING.equals(schemaName) ? "AND
TABLE_SCHEM = \'"
Review comment:
Nit: Add space before AND
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services