gjacoby126 commented on a change in pull request #666: Phoenix-5652 Improve
IndexScrutinyTool perf by using SkipScan in index table queries
URL: https://github.com/apache/phoenix/pull/666#discussion_r365359999
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexScrutinyToolIT.java
##########
@@ -165,19 +167,23 @@ public IndexScrutinyToolIT(String dataTableDdl, String
indexTableDdl) {
@Test public void testScrutinyOnArrayTypes() throws Exception {
String dataTableName = generateUniqueName();
String indexTableName = generateUniqueName();
- String dataTableDDL = "CREATE TABLE %s (ID INTEGER NOT NULL PRIMARY
KEY, NAME VARCHAR, VB VARBINARY)";
+ String
+ dataTableDDL =
+ "CREATE TABLE %s (ID INTEGER NOT NULL PRIMARY KEY, NAME
VARCHAR, VB VARBINARY)";
String indexTableDDL = "CREATE INDEX %s ON %s (NAME) INCLUDE (VB)";
String upsertData = "UPSERT INTO %s VALUES (?, ?, ?)";
String upsertIndex = "UPSERT INTO %s (\"0:NAME\", \":ID\", \"0:VB\")
values (?,?,?)";
- try (Connection conn =
- DriverManager.getConnection(getUrl(),
PropertiesUtil.deepCopy(TEST_PROPERTIES))) {
+ try (Connection conn = DriverManager.getConnection(getUrl(),
PropertiesUtil.deepCopy(TEST_PROPERTIES))) {
conn.createStatement().execute(String.format(dataTableDDL,
dataTableName));
- conn.createStatement().execute(String.format(indexTableDDL,
indexTableName, dataTableName));
+ conn.createStatement()
+ .execute(String.format(indexTableDDL, indexTableName,
dataTableName));
// insert two rows
- PreparedStatement upsertDataStmt =
conn.prepareStatement(String.format(upsertData, dataTableName));
- upsertRow(upsertDataStmt, 1, "name-1", new byte[] {127, 0, 0, 1});
- upsertRow(upsertDataStmt, 2, "name-2", new byte[] {127, 1, 0, 5});
+ PreparedStatement
+ upsertDataStmt =
Review comment:
ditto upsertDataStmt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
