gjacoby126 commented on a change in pull request #666: Phoenix-5652 Improve
IndexScrutinyTool perf by using SkipScan in index table queries
URL: https://github.com/apache/phoenix/pull/666#discussion_r365365829
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/IndexColumnNames.java
##########
@@ -61,8 +67,13 @@ public IndexColumnNames(final PTable pdataTable, final
PTable pindexTable) {
if (pindexTable.getViewIndexId() != null) {
offset++;
}
- if (pindexTable.isMultiTenant() && pindexTable.getViewIndexId() !=
null) {
- offset++;
+
+ if (tenantId != null) {
+ // For multi tenant view indexes, in order for skipscan to be
used, we need tenant column.
+ // For tenant connections this column is not visible.
+ if (pindexTable.isMultiTenant() && pindexTable.getViewIndexId() !=
null) {
Review comment:
@gokceni Wouldn't you also need this for multi-tenant global indexes not on
a view?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
