gjacoby126 commented on issue #679: PHOENIX-5645 - GlobalIndexChecker should 
prevent compaction from purg…
URL: https://github.com/apache/phoenix/pull/679#issuecomment-574391260
   Some notes:
   1. Everything now uses the EnvironmentEdgeManager rather than Thread.sleeps 
to fix the non-deterministic behavior of the original version
   2. The TTL test now has a longer TTL than max lookback age, which is correct 
(the original test was written before we decided that   scn age <= max lookback 
age < ttl
   3. All tests pass in < 30s on my laptop, when before most of the tests took 
30s each. 
   4. I removed the index assertions; they were making things more complicated 
and since this functionality is part of all Phoenix tables now, didn't seem to 
have much benefit. 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to