gjacoby126 commented on a change in pull request #679: PHOENIX-5645 -
BaseScannerRegionObserver should prevent compaction from purg…
URL: https://github.com/apache/phoenix/pull/679#discussion_r366622629
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/MaxLookbackIT.java
##########
@@ -105,60 +129,52 @@ public void testTooLowSCNWithMaxLookbackAge() throws
Exception {
public void testRecentlyDeletedRowsNotCompactedAway() throws Exception {
try (Connection conn = DriverManager.getConnection(getUrl())) {
String dataTableName = generateUniqueName();
- String indexStem = generateUniqueName();
- createTableAndIndexes(conn, dataTableName, indexStem);
- String fullIndexName = indexStem + "1";
+ createTable(dataTableName);
+ injectEdge.incValue(WAIT_AFTER_TABLE_CREATION);
Review comment:
The ManualEnvironmentEdge is copied from HBase code, where that's the method
name. I couldn't use the HBase class because Phoenix's EEM is odd and requires
a specific abstract subclass of Edge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
