[
https://issues.apache.org/jira/browse/PHOENIX-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021774#comment-17021774
]
Lars Hofhansl commented on PHOENIX-5677:
----------------------------------------
Cool. Missed that. Fine to disable/remove the test. Perhaps I would not
outright remove it, but disable it instead... In case it's fine.
BTW. With my above comment I just meant to say it's fine to break the tests.
(My comments on the mailing list were about leaving suite broken for long
durations.)
> Replace System.currentTimeMillis with EnvironmentEdgeManager in non-test code
> -----------------------------------------------------------------------------
>
> Key: PHOENIX-5677
> URL: https://issues.apache.org/jira/browse/PHOENIX-5677
> Project: Phoenix
> Issue Type: Bug
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5677-4.x-HBase-1.3.patch,
> PHOENIX-5677-addendum-4.x-HBase-1.3.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Phoenix is inconsistent in using either system clock or
> EnvironmentEdgeManager to get current time. The EnvironmentEdgeManager is
> occasionally very useful in tests to control time deterministically without
> needing to sleep. Direct references to System.currentTimeMillis in non-test
> code should be switched over.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
