[
https://issues.apache.org/jira/browse/PHOENIX-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021777#comment-17021777
]
Hadoop QA commented on PHOENIX-5677:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12991590/PHOENIX-5677-addendum-4.x-HBase-1.3.patch
against 4.x-HBase-1.3 branch at commit
5968d3ba8348067775dc2751f06eaa8155a633d5.
ATTACHMENT ID: 12991590
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3335//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3335//console
This message is automatically generated.
> Replace System.currentTimeMillis with EnvironmentEdgeManager in non-test code
> -----------------------------------------------------------------------------
>
> Key: PHOENIX-5677
> URL: https://issues.apache.org/jira/browse/PHOENIX-5677
> Project: Phoenix
> Issue Type: Bug
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5677-4.x-HBase-1.3.patch,
> PHOENIX-5677-addendum-4.x-HBase-1.3.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Phoenix is inconsistent in using either system clock or
> EnvironmentEdgeManager to get current time. The EnvironmentEdgeManager is
> occasionally very useful in tests to control time deterministically without
> needing to sleep. Direct references to System.currentTimeMillis in non-test
> code should be switched over.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
